From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read
Date: Mon, 16 Nov 2009 06:03:31 -0500 [thread overview]
Message-ID: <20091116110331.GA19835@infradead.org> (raw)
In-Reply-To: <20091116031512.GC9467@discord.disaster>
On Mon, Nov 16, 2009 at 02:15:12PM +1100, Dave Chinner wrote:
> On Sat, Nov 14, 2009 at 11:17:19AM -0500, Christoph Hellwig wrote:
> > The two interfaces are highl confusing as they do have a flags argument
> > which gets ignored and replaced with default flags. Switch the few remaining
> > callers to use xfs_buf_get_flags and xfs_buf_read_flags instead and remove
> > these wrappers.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Personally I would have dropped the *_flags from the function names
> as well (so everything calls xfs_buf_get() or xfs_buf_read()) but
> it doesn't really matter....
Maybe. The issue would be if we forward-port some code that expects it
can pass random crap in the flags field will get different behaviour
now. Then again it'll blow up fast enough to notice..
> > + XFS_AGB_TO_DADDR(mp, agno, XFS_BNO_BLOCK(mp)),
> > + BTOBB(mp->m_sb.sb_blocksize), XBF_LOCK | XBF_MAPPED);
>
> That looks wider than 80 columns. Same for the other conversions,
> too.
I'll fix it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-16 11:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 16:17 [PATCH 0/7] assorted cleanups Christoph Hellwig
2009-11-14 16:17 ` [PATCH 1/7] xfs: remove IO_ISAIO Christoph Hellwig
2009-11-16 3:05 ` Dave Chinner
2009-11-19 4:36 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read Christoph Hellwig
2009-11-16 3:15 ` Dave Chinner
2009-11-16 11:03 ` Christoph Hellwig [this message]
2009-11-19 4:40 ` Eric Sandeen
2009-11-24 18:02 ` [PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces Christoph Hellwig
2009-11-25 0:16 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 3/7] xfs: rename xfs_attr_fetch to xfs_attr_get_int Christoph Hellwig
2009-11-16 3:17 ` Dave Chinner
2009-11-19 4:42 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 4/7] xfs: uninline xfs_get_extsz_hint Christoph Hellwig
2009-11-16 3:18 ` Dave Chinner
2009-11-19 4:51 ` Eric Sandeen
2009-11-14 16:17 ` [PATCH 5/7] xfs: kill the STATIC_INLINE macro Christoph Hellwig
2009-11-16 3:20 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 6/7] xfs: remove incorrect sparse annotation for xfs_iget_cache_miss Christoph Hellwig
2009-11-16 3:22 ` Dave Chinner
2009-11-14 16:17 ` [PATCH 7/7] xfs: cleanup dmapi macros in the umount path Christoph Hellwig
2009-11-16 3:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116110331.GA19835@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox