From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: improve metadata I/O merging in the elevator
Date: Mon, 16 Nov 2009 06:05:23 -0500 [thread overview]
Message-ID: <20091116110523.GB19835@infradead.org> (raw)
In-Reply-To: <20091116035019.GI9467@discord.disaster>
On Mon, Nov 16, 2009 at 02:50:19PM +1100, Dave Chinner wrote:
> Definitely should be done, but....
>
> It looks like the patch you posted isn't quite doing what was
> intended - async write buffers are being classified as WRITE, not
> WRITE_META. That means we get more write combining in the elevator
> (performance increase) like with WRITE_META, but don't get the
> faster dispatch (latency reduction) by using the META queue to keep
> the metadata writeback separate from the bulk data writeback.
> That may be why deadline is not showing any improvement...
>
> FWIW, the original patch here:
>
> http://oss.sgi.com/archives/xfs/2008-01/msg00630.html
>
> uses WRITE_META, but it looks like you've taken bits of this
> patch:
Indeed. I'l re-add the write-side markings and will re-bench and
re-submit.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-16 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 19:09 [PATCH] xfs: improve metadata I/O merging in the elevator Christoph Hellwig
2009-11-16 3:50 ` Dave Chinner
2009-11-16 11:05 ` Christoph Hellwig [this message]
2009-11-24 18:03 ` [PATCH v2] " Christoph Hellwig
2009-12-15 20:12 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116110523.GB19835@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox