From: Christoph Hellwig <hch@infradead.org>
To: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: XFS bug in log recover with quota (bugzilla id 855)
Date: Mon, 16 Nov 2009 08:08:24 -0500 [thread overview]
Message-ID: <20091116130824.GA27442@infradead.org> (raw)
In-Reply-To: <20091116115702.GN23522@sith.mimuw.edu.pl>
On Mon, Nov 16, 2009 at 12:57:02PM +0100, Jan Rekorajski wrote:
> Hi,
> I was hit by a bug in linux 2.6.31 when XFS is not able to recover the
> log after a crash if fs was mounted with quotas. Gory details in XFS
> bugzilla: http://oss.sgi.com/bugzilla/show_bug.cgi?id=855.
>
> It looks like wrong struct is used in buffer length check, and the following
> patch should fix the problem.
>
> xfs_dqblk_t has a size of 104+32 bytes, while xfs_disk_dquot_t is 104 bytes
> long, and this is exactly what I see in system logs - "XFS: dquot too small
> (104) in xlog_recover_do_dquot_trans."
Yikes, great brown paperbag bug. Indeed, as per
xfs_qm_dquot_logitem_format() we only log the xfs_disk_dquot_t and not
the full xfs_dqblk_t.
Felix, can you try to get this to Linus before .32 as this is clearly a
regression.
I'll also put the writing of more quota testcases including testing the
log recovery even higher on my todo list.
Reviewed-by: Christoph Hellwig <hch@lst.de>
> --- linux-2.6.31.5/fs/xfs/xfs_log_recover.c.orig 2009-11-01 23:59:52.194846209 +0100
> +++ linux-2.6.31.5/fs/xfs/xfs_log_recover.c 2009-11-16 12:47:11.601490963 +0100
> @@ -1980,7 +1980,7 @@
> "XFS: NULL dquot in %s.", __func__);
> goto next;
> }
> - if (item->ri_buf[i].i_len < sizeof(xfs_dqblk_t)) {
> + if (item->ri_buf[i].i_len < sizeof(xfs_disk_dquot_t)) {
> cmn_err(CE_ALERT,
> "XFS: dquot too small (%d) in %s.",
> item->ri_buf[i].i_len, __func__);
> @@ -2636,7 +2636,7 @@
> "XFS: NULL dquot in %s.", __func__);
> return XFS_ERROR(EIO);
> }
> - if (item->ri_buf[1].i_len < sizeof(xfs_dqblk_t)) {
> + if (item->ri_buf[1].i_len < sizeof(xfs_disk_dquot_t)) {
> cmn_err(CE_ALERT,
> "XFS: dquot too small (%d) in %s.",
> item->ri_buf[1].i_len, __func__);
>
> --
> Jan Rekorajski | ALL SUSPECTS ARE GUILTY. PERIOD!
> baggins<at>mimuw.edu.pl | OTHERWISE THEY WOULDN'T BE SUSPECTS, WOULD THEY?
> BOFH, MANIAC | -- TROOPS by Kevin Rubio
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-16 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 11:57 XFS bug in log recover with quota (bugzilla id 855) Jan Rekorajski
2009-11-16 13:08 ` Christoph Hellwig [this message]
2009-11-16 14:29 ` Eric Sandeen
2009-11-16 15:55 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116130824.GA27442@infradead.org \
--to=hch@infradead.org \
--cc=baggins@sith.mimuw.edu.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox