From: Christoph Hellwig <hch@infradead.org>
To: "Nathaniel W. Turner" <nate@houseofnate.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: copy li_lsn before dropping AIL lock
Date: Tue, 17 Nov 2009 10:13:18 -0500 [thread overview]
Message-ID: <20091117151318.GA19893@infradead.org> (raw)
In-Reply-To: <4B01AD54.3030008@houseofnate.net>
On Mon, Nov 16, 2009 at 02:51:48PM -0500, Nathaniel W. Turner wrote:
> Access to log items on the AIL is generally protected by m_ail_lock;
> this is particularly needed when we're getting or setting the 64-bit
> li_lsn on a 32-bit platform. This patch fixes a couple places where we
> were accessing the log item after dropping the AIL lock on 32-bit
> machines.
>
> This can result in a partially-zeroed log->l_tail_lsn if
> xfs_trans_ail_delete is racing with xfs_trans_ail_update, and in at
> least some cases, this can leave the l_tail_lsn with a zero cycle
> number, which means xlog_space_left will think the log is full (unless
> CONFIG_XFS_DEBUG is set, in which case we'll trip an ASSERT), leading to
> processes stuck forever in xlog_grant_log_space.
Might this also cause this oops?
http://www.kerneloops.org/raw.php?rawid=944396&msgid=
It's been shoving up a few times recently.
Anyway, the patch looks good to me, but I wonder if we should abstract
the li_lsn handling a bit more to avoid easily running into this kind of
problems.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-17 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 19:51 [PATCH] xfs: copy li_lsn before dropping AIL lock Nathaniel W. Turner
2009-11-17 15:13 ` Christoph Hellwig [this message]
2009-11-17 21:48 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117151318.GA19893@infradead.org \
--to=hch@infradead.org \
--cc=nate@houseofnate.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox