From: Christoph Hellwig <hch@infradead.org>
To: david@fromorbit.com
Cc: xfs@oss.sgi.com
Subject: protecting per-ag access in the sync path
Date: Tue, 24 Nov 2009 12:04:55 -0500 [thread overview]
Message-ID: <20091124170455.GA9021@infradead.org> (raw)
Since Linux 2.6.29 we use the perag structures a lot in the sync path,
but we're not actually protecting against the re-allocation in growfs.
I've recently received a new, fast SSD which allows me to hit those
races. With it 104 reproducibly crashes the system, hitting the slab
redzoning for the old per-ag structure. I experimentally put
synchronization using m_peraglock into xfs_inode_ag_walk which fixes the
issue at the cost of lock order reversals between the i_lock and the
m_peraglock in various places.
Any better idea how to protect the new sync path against growfs?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-11-24 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 17:04 Christoph Hellwig [this message]
2009-11-25 0:05 ` protecting per-ag access in the sync path Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124170455.GA9021@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox