From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: check for not fully initialized inodes in xfs_ireclaim
Date: Mon, 30 Nov 2009 15:33:49 -0500 [thread overview]
Message-ID: <20091130203349.GB16127@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE83AF45@cf--amer001e--3.americas.sgi.com>
On Mon, Nov 30, 2009 at 02:07:40PM -0600, Alex Elder wrote:
> Christoph Hellwig wrote:
> > Add an assert for inodes not added to the inode cache in xfs_ireclaim, to make
> > sure we're not going to introduce something like the famous nfsd inode cache
> > bug again.
>
> I confess I have not looked at the radix tree
> code in detail yet, but radix_tree_delete()
> returns a value that is ignored here. It reportedly
> will return a null pointer if the index has no
> corresponding item in the tree, so this could be
> used in the assertion rather than doing a separate
> lookup.
>
> I think the change is fine, but would rather see
> it done without the extra lookup (though there may
> be a good reason for doing it anyway).
Sounds good, I'll redo it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-30 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 19:06 [PATCH] xfs: check for not fully initialized inodes in xfs_ireclaim Christoph Hellwig
2009-11-30 20:07 ` Alex Elder
2009-11-30 20:33 ` Christoph Hellwig [this message]
2009-12-01 18:12 ` [PATCH V2] " Christoph Hellwig
2009-12-15 20:05 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130203349.GB16127@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox