From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] db: stop using xfs_bmbt_rec_32_t
Date: Fri, 4 Dec 2009 05:04:01 -0500 [thread overview]
Message-ID: <20091204100401.GA28986@infradead.org> (raw)
In-Reply-To: <4B16A5E8.8070604@sandeen.net>
On Wed, Dec 02, 2009 at 11:37:44AM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > xfs_db uses the xfs_bmbt_rec_32_t type to pass around extent information in a
> > few places. But everywhere where we actually use it we use the normal
> > xfs_bmbt_rec_t just casting from/to xfs_bmbt_rec_32_t to pass it around.
> >
> > Just pass the xfs_bmbt_rec_t directly and thus get rid of the last use
> > of xfs_bmbt_rec_32_t in xfsprogs.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Seems fine.
>
> After this should the db references to xfs_bmbt_rec_64_t be
> changed to xfs_bmbt_rec_t perhaps?
Yes, except that we don't actually have the struct type for it yet which
we'll need in at least one place. I'll do it once I've removed the _32
and _64 types in the kernel and synced over the changes to userspace.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-12-04 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 15:50 [PATCH] db: stop using xfs_bmbt_rec_32_t Christoph Hellwig
2009-11-25 21:10 ` Christoph Hellwig
2009-12-02 17:37 ` Eric Sandeen
2009-12-04 10:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204100401.GA28986@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox