From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777
Date: Thu, 10 Dec 2009 04:08:54 -0500 [thread overview]
Message-ID: <20091210090854.GA29653@infradead.org> (raw)
In-Reply-To: <4B2073D1.1040809@sandeen.net>
On Wed, Dec 09, 2009 at 10:06:41PM -0600, Eric Sandeen wrote:
> This addresses Debian bug #559490 - xfsdump: fsr creates files mode 666
>
> I think that this mode is left over from when xfs_fsr used to
> fork into the uid of the file's owner, and so needed somewhere
> it was guaranteed to be able to write.
>
> This behavior was removed in commit d51b892411c8d33374a02e20c5888df280811549
> (in the xfsdump tree, before xfs_fsr got moved) and so these
> wide-open permissions should no longer be needed.
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-12-10 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 4:06 [PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777 Eric Sandeen
2009-12-10 9:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210090854.GA29653@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox