From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] add lpath_to_handle to libhandle
Date: Wed, 23 Dec 2009 08:15:35 -0500 [thread overview]
Message-ID: <20091223131535.GA23394@infradead.org> (raw)
In-Reply-To: <4B300B2F.7080305@sgi.com>
> Based on Christoph's suggestion here's a rework of the patch
> (that I've been sitting on for a while). This requires no change
> to the libhandle API and no changes in xfsdump (and hence just
> this one patch. The previously posted patch 2/2 is dropped).
The patch looks good for me from review, but fails to apply probably due
to whitespace damage in the mailer.
One thing that could be changes is to also do the fspath conversion for
block and chacater special files. While we can open those they will not
end up in the xfs file operations and thus not provide the nessecary
ioctl.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, it would be nice if you could write a testcase for xfstests that
fails with the old version on links but works with the new one.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-12-23 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 16:52 [PATCH 1/2] add lpath_to_handle to libhandle Bill Kendall
2009-10-23 18:08 ` Alex Elder
2009-10-24 13:37 ` Christoph Hellwig
2009-10-25 2:52 ` Christoph Hellwig
2009-10-24 13:39 ` Christoph Hellwig
2009-12-21 23:56 ` Bill Kendall
2009-12-23 13:15 ` Christoph Hellwig [this message]
2009-12-23 19:21 ` Bill Kendall
2010-01-06 17:41 ` Christoph Hellwig
2009-10-25 3:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223131535.GA23394@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox