From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id nBNDUrGZ237967 for ; Wed, 23 Dec 2009 07:30:53 -0600 Date: Wed, 23 Dec 2009 08:31:36 -0500 From: Christoph Hellwig Subject: Re: [PATCH] use time32_t consistently in xfsdump tree Message-ID: <20091223133136.GA10345@infradead.org> References: <4B300389.7020905@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4B300389.7020905@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Bill Kendall Cc: xfs@oss.sgi.com On Mon, Dec 21, 2009 at 05:23:53PM -0600, Bill Kendall wrote: > xfsdump stores time_t as 32-bits in its dump and inventory > structures for portability/historical reasons. xfsinvutil > uses time_t directly, leading to some strange results on > systems which have a 64-bit time_t. > > The 32-bit time-related functions were factored out into > their own file since they are now used by xfsinvutil, and > their original file (util.c) could not easily be linked > with xfsinvutil due to dependencies on many other > dump/restore modules. The newly created timeutil.[ch] did not get included into the patch, so I can't easily review them, and the rest of the patch also seems whitespace mangled to me. The changes in it looks good, just the time_t to time32_t conversions plus overflow checks. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs