From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] improve xfsinvutil man page and argument processing
Date: Wed, 23 Dec 2009 10:58:44 -0500 [thread overview]
Message-ID: <20091223155844.GC28192@infradead.org> (raw)
In-Reply-To: <20091223155713.GB28192@infradead.org>
On Wed, Dec 23, 2009 at 10:57:13AM -0500, Christoph Hellwig wrote:
> Some notes to look into after this patch:
>
> - can you provide a testcase for the problems caused by the wrong
> time_t usage? A patch to xfstests would be perfect, but if you
> have a raw testcase I'll vounteer to wire it up.
> - why do we wrap both ctime and ctime_r? Currently xfsdump isn't
> multithreaded so we shouldn't need it. But if the parallel
> dump/restore ever gets merged from IRIX we need to get rid of the
> plain ctime calls. (Btw, are there any plans for the parallel
> dump/restore port?)
Err, sorry - thos comments were for the time32 patch, but this patch
also looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-12-23 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 23:30 [PATCH] improve xfsinvutil man page and argument processing Bill Kendall
2009-12-23 13:33 ` Christoph Hellwig
2009-12-23 15:20 ` Bill Kendall
2009-12-23 15:57 ` Christoph Hellwig
2009-12-23 15:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223155844.GC28192@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox