From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id nBNFw2op247695 for ; Wed, 23 Dec 2009 09:58:02 -0600 Date: Wed, 23 Dec 2009 10:58:44 -0500 From: Christoph Hellwig Subject: Re: [PATCH] improve xfsinvutil man page and argument processing Message-ID: <20091223155844.GC28192@infradead.org> References: <4B300507.1070502@sgi.com> <20091223133321.GA10982@infradead.org> <20091223152057.GA21306@sgi.com> <20091223155713.GB28192@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20091223155713.GB28192@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Bill Kendall Cc: Christoph Hellwig , xfs@oss.sgi.com On Wed, Dec 23, 2009 at 10:57:13AM -0500, Christoph Hellwig wrote: > Some notes to look into after this patch: > > - can you provide a testcase for the problems caused by the wrong > time_t usage? A patch to xfstests would be perfect, but if you > have a raw testcase I'll vounteer to wire it up. > - why do we wrap both ctime and ctime_r? Currently xfsdump isn't > multithreaded so we shouldn't need it. But if the parallel > dump/restore ever gets merged from IRIX we need to get rid of the > plain ctime calls. (Btw, are there any plans for the parallel > dump/restore port?) Err, sorry - thos comments were for the time32 patch, but this patch also looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs