From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] repair: compare superblock / AG headers fields against manual counts
Date: Thu, 31 Dec 2009 09:43:14 +1100 [thread overview]
Message-ID: <20091230224314.GD13802@discord.disaster> (raw)
In-Reply-To: <20091201151037.707510379@bombadil.infradead.org>
On Tue, Dec 01, 2009 at 10:05:06AM -0500, Christoph Hellwig wrote:
> Compare the free block / inode counters in the superblock and AG headers
> against the values we get from a manual btree traversal. Ported over from
> xfs_db to get the same amount of superblock / AG header checking as in
> xfs_check.
>
>
> Note: this causes additional output in the xfstests 030 and 178 which will need
> some adjustments in the testcases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
.....
> @@ -550,6 +583,10 @@ _("%s freespace btree block claimed (sta
> lastblock = b;
> }
> } else {
> + fdblocks += len;
> + agffreeblks += len;
> + if (len > agflongest)
> + agflongest = len;
> if (len < lastcount) {
> do_warn(_(
> "out-of-order cnt btree record %d (%u %u) block %u/%u\n"),
Might be worth a comment here saying that we are only calculating
totals from the ABTC btree scan. OTOH, is is worth checking that the
two btrees add up to the same number of free blocks, same maximum
length extent, etc?
Otherwise looks good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-12-30 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 15:05 [PATCH 0/3] repair btree validation improvements Christoph Hellwig
2009-12-01 15:05 ` [PATCH 1/3] repair: fix freespace btree record validation Christoph Hellwig
2009-12-30 22:25 ` Dave Chinner
2009-12-01 15:05 ` [PATCH 2/3] repair: add more fresspace btree checks Christoph Hellwig
2009-12-30 22:26 ` Dave Chinner
2009-12-01 15:05 ` [PATCH 3/3] repair: compare superblock / AG headers fields against manual counts Christoph Hellwig
2009-12-30 22:43 ` Dave Chinner [this message]
2010-01-02 11:10 ` Christoph Hellwig
2009-12-23 13:55 ` [PATCH 0/3] repair btree validation improvements Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091230224314.GD13802@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox