From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Ensure we force all busy extents in range to disk
Date: Sat, 2 Jan 2010 06:23:29 -0500 [thread overview]
Message-ID: <20100102112329.GA27329@infradead.org> (raw)
In-Reply-To: <1262399936-19195-1-git-send-email-david@fromorbit.com>
Looks good, and quite interestin that we never could it before.
Some nipicks below:
> + /*
> + * search pagb_list for this slot, skipping open slots. We have to
> + * search the entire array as there may be multiple overlaps and
> + * we have to get the most recent LSN for the log force to push out
> + * all the transactions that span the range.
> + */
> + for (bsy = pag->pagb_list; cnt; bsy++, cnt--) {
Maybe you coult convert this to a more standard loop idiom while you're
at it:
for (cnt = 0; cnt < pag->pagb_count; cnt++) {
bsy = &pag->pagb_list[cnt];
> + if (!bsy->busy_tp)
> + continue;
>
> + bend = bsy->busy_start + bsy->busy_length - 1;
> + if ((bno > bend) || (uend < bsy->busy_start))
no need for the inner braces here.
And btw, the standard subsystem prefix is all lower case, xfs:, not
XFS:.
Also it seems like this patch requires your perag-lookup fixes first.
Time to get them into the for-2.6.34 git tree ASAP as a base to work
against. That might also make it easier to work on the lockless patch
separately.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-02 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 2:38 [PATCH] XFS: Ensure we force all busy extents in range to disk Dave Chinner
2010-01-02 11:23 ` Christoph Hellwig [this message]
2010-01-02 12:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100102112329.GA27329@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox