From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Kill filestreams cache flush
Date: Sat, 2 Jan 2010 23:12:03 +1100 [thread overview]
Message-ID: <20100102121203.GG13802@discord.disaster> (raw)
In-Reply-To: <20100102115338.GA18502@infradead.org>
On Sat, Jan 02, 2010 at 06:53:38AM -0500, Christoph Hellwig wrote:
> On Sat, Jan 02, 2010 at 01:38:20PM +1100, Dave Chinner wrote:
> > The filestreams cache flush is not needed in the sync code as it
> > does not affect data writeback, and it is now not used by the
> > growfs code, either, so kill it.
>
> I have to admit I never understood the purpose of this call.
I can't remember why it was put there, either. I may have even put
it there when I was getting filestreams ready for merge but I can't remember
at all...
> What xfs_fstrm_free_func does is:
>
> - clear the filesystems flag on the inode
> - decrement pagf_fstrms
> - drop references on the inode (and parent if known)
> - free the filestream item
>
> Nothing of that should matter for sync, although dropping inode
> references during sync might generally be a good idea.
Which means that sync destroys active filestreams associations and
that seems more broken to me than anything an active reference will
cause. I think just letting them time out is better than having them
destroyed by external operations. I'm happy to leave it there if you
want....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-02 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 2:38 [PATCH] XFS: Kill filestreams cache flush Dave Chinner
2010-01-02 11:53 ` Christoph Hellwig
2010-01-02 12:12 ` Dave Chinner [this message]
2010-01-02 12:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100102121203.GG13802@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox