public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Don't flush stale inodes
Date: Sat, 2 Jan 2010 08:17:01 -0500	[thread overview]
Message-ID: <20100102131701.GA17320@infradead.org> (raw)
In-Reply-To: <20100102122405.GI13802@discord.disaster>

This looks like a bigger problem to me.  We only mark inodes as stale
from xfs_ifree_cluster, which via xfs_ifree and xfs_inactive gets
called from xfs_fs_clear_inode.  Given that the inode has now been
deleted we should not mark it as reclaimable in xfs_fs_destroy_inode
but go on to reap it given that there is nothing to reclaim.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-01-02 13:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02  2:39 [PATCH] XFS: Don't flush stale inodes Dave Chinner
2010-01-02 12:00 ` Christoph Hellwig
2010-01-02 12:14   ` Dave Chinner
2010-01-02 12:24   ` Dave Chinner
2010-01-02 13:17     ` Christoph Hellwig [this message]
2010-01-02 13:39       ` Dave Chinner
2010-01-08 20:59 ` Alex Elder
2010-01-08 23:14 ` [PATCH v2] xfs: " Alex Elder
2010-01-09  0:09   ` Dave Chinner
2010-01-09 16:22     ` Alex Elder
2010-01-09 22:39       ` Dave Chinner
2010-01-10 16:43         ` Alex Elder
2010-01-09 18:10     ` [PATCH, updated] xfs: Ensure we force all busy extents in range to disk Alex Elder
2010-01-09 19:35       ` Christoph Hellwig
2010-01-10 18:28         ` [PATCH, updated] xfs: Ensure we force all busy extents inrange " Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100102131701.GA17320@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox