From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] XFS: Don't wake xfsbufd when idle
Date: Mon, 4 Jan 2010 10:20:48 -0500 [thread overview]
Message-ID: <20100104152048.GC24810@infradead.org> (raw)
In-Reply-To: <1262400215-19443-3-git-send-email-david@fromorbit.com>
On Sat, Jan 02, 2010 at 01:43:35PM +1100, Dave Chinner wrote:
> The xfsbufd wakes every xfsbufd_centisecs (once per second by
> default) for each filesystem even when the filesystem is idle.
> If the xfsbufd has nothing to do, put it into a long term sleep
> and only wake it up when there is work pending (i.e. dirty
> buffers to flush soon). This will make laptop power misers happy.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> ---
> fs/xfs/linux-2.6/xfs_buf.c | 28 +++++++++++++++++++---------
> 1 files changed, 19 insertions(+), 9 deletions(-)
>
> STATIC int xfsbufd(void *);
> -STATIC int xfsbufd_wakeup(int, gfp_t);
> +STATIC int xfsbufd_wakeup_all(int, gfp_t);
this rename seems unrelated to the rest of the patch.
> @@ -1595,6 +1595,11 @@ xfs_buf_delwri_queue(
> list_del(&bp->b_list);
> }
>
> + if (list_empty(dwq)) {
> + /* start xfsbufd as it has something to do now */
> + wake_up_process(bp->b_target->bt_task);
> + }
Does it make sense to wake xfsbufd before actually adding the item and
unlocking the queue lock? Shouldn't this be defered until after the
addition?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-04 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 2:43 [PATCH 0/2] XFS: Run kernel threads on demand Dave Chinner
2010-01-02 2:43 ` [PATCH 1/2] XFS: Don't wake the aild once per second Dave Chinner
2010-01-04 15:16 ` Christoph Hellwig
2010-01-04 23:28 ` Dave Chinner
2010-01-02 2:43 ` [PATCH 2/2] XFS: Don't wake xfsbufd when idle Dave Chinner
2010-01-04 15:20 ` Christoph Hellwig [this message]
2010-01-04 23:52 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104152048.GC24810@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox