From: Christoph Hellwig <hch@infradead.org>
To: Christian Kujau <lists@nerdbynature.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] use CFLAGS in src/Makefile
Date: Wed, 6 Jan 2010 11:39:53 -0500 [thread overview]
Message-ID: <20100106163953.GA4209@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.01.1001021409290.3483@bogon.housecafe.de>
On Sat, Jan 02, 2010 at 02:16:08PM -0800, Christian Kujau wrote:
> Hi,
>
> while compiling xfstests after configuring with a different CFLAGS value,
> gcc fails in ./src:
>
> [...]
> make[2]: Entering directory `/usr/local/src/xfstests-git/src'
> gcc -g -O2 -DDEBUG -I../include -DVERSION=\"1.0.0\" -L/opt/xfsprogs/lib
> -DREAD iopat.c -o preallo_rw_pattern_reader
> iopat.c:21:21: error: xfs/xfs.h: No such file or directory
> [...]
>
> Somehow CFLAGS isn't passed to gcc, but "GCFLAGS" is. I'm not too savvy
> with the xfstests build system, but in include/builddefs.in we see:
>
> # Global, Platform, Local CFLAGS
> CFLAGS += $(GCFLAGS) $(PCFLAGS) $(LCFLAGS)
>
> ...thus I'm proposing the following fix:
This looks correct, or at least better than what we had before.
But I really dislike how we defeat the abstraction used for compiling
all the other tools.
What might be better is to add a small
preallo_rw_pattern_writer.c file that just contains:
#define WRITE
#include iopat.c
and the same for the reader side and use the normal rules to compile
the program.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-06 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 22:16 [PATCH] use CFLAGS in src/Makefile Christian Kujau
2010-01-06 16:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106163953.GA4209@infradead.org \
--to=hch@infradead.org \
--cc=lists@nerdbynature.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox