From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Artem Bityutskiy <dedekind@infradead.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Dave Airlie <airlied@redhat.com>,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH V3] sort: Introduce generic list_sort function
Date: Wed, 6 Jan 2010 12:23:19 -0500 [thread overview]
Message-ID: <20100106172319.GA25046@infradead.org> (raw)
In-Reply-To: <20100105125234.GD1778@basil.fritz.box>
On Tue, Jan 05, 2010 at 01:52:35PM +0100, Andi Kleen wrote:
> > > Also it would seem cleaner to have it in a own file.
> >
> > That might make sense if we had a large number of generic sort
> > functions and it was difficult to tell the code apart, but we've
> > only got 2 right now....
>
> I was more thinking of the case that it can be easily made a lib-y
> and then eliminated by the linker on non modular kernels if not needed
> (unfortunately that would require putting the EXPORT_SYMBOL somewhere else)
lib-y doesn't work together with EXPORT_SYMBOL, having the export
outside would also always pull it in. These days the whole lib-y mess
doesn't make sense anymore - if we really need an optional library
symbol we can just pull it in through a Kconfig variable.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-06 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1262649295-28427-1-git-send-email-david__25057.2445955642$1262651404$gmane$org@fromorbit.com>
2010-01-05 11:31 ` [PATCH] sort: Introduce generic list_sort function Andi Kleen
2010-01-05 12:21 ` [PATCH V3] " Dave Chinner
2010-01-05 12:52 ` Andi Kleen
2010-01-06 17:23 ` Christoph Hellwig [this message]
2010-01-06 19:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106172319.GA25046@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@nokia.com \
--cc=airlied@redhat.com \
--cc=andi@firstfloor.org \
--cc=dedekind@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox