public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: LKML <linux-kernel@vger.kernel.org>, xfs@oss.sgi.com
Subject: Re: lockdep: inconsistent lock state
Date: Wed, 6 Jan 2010 12:36:29 -0500	[thread overview]
Message-ID: <20100106173628.GA14148@infradead.org> (raw)
In-Reply-To: <20091227212700.GA7613@discord.disaster>

On Mon, Dec 28, 2009 at 08:27:00AM +1100, Dave Chinner wrote:
> This is the usual false positive that is detected - XFS takes locks in
> reclaim that it also takes in non-reclaim paths. The reclaim path
> from kswapd inverts lock ordering and so we get this report. This
> case has never been a deadlock case because an inode in reclaim
> cannot be referenced by any other path, so once again it is a
> false positive....

This should be gone in 2.6.33-rc as we now tell lockdep about resetting
the dependency graph for the iolock once entering the inode reclaim path.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2010-01-06 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-26 21:07 lockdep: inconsistent lock state Christian Kujau
2009-12-27 21:27 ` Dave Chinner
2009-12-27 22:01   ` Christian Kujau
2010-01-06 17:36   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100106173628.GA14148@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox