public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alex Elder <aelder@sgi.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [GIT PULL] XFS update for 2.6.33-rc1
Date: Fri, 8 Jan 2010 09:44:28 -0800	[thread overview]
Message-ID: <20100108094428.ff03c720.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A687F@cf--amer001e--3.americas.sgi.com>

On Wed, 16 Dec 2009 21:41:12 -0600 Alex Elder wrote:

> Dave Chinner wrote:
> > On Wed, Dec 16, 2009 at 01:55:12PM -0800, Randy Dunlap wrote:
> >> On Wed, 16 Dec 2009 15:26:10 -0600 Alex Elder wrote:
> >> 
> >>> One more XFS update for -rc1, now that the new XFS tracing code has
> >>> been committed.
> >> 
> >> Sorry if I have missed it, but have the printk format warnings
> >> on i386 builds been fixed?
> > 
> > I don't see any here w/ gcc 4.3.4 x86-64 compiling i386 kernels....
> 
> I didn't get them either when I built in my environment.
> 
> Dave, your patch looks good to me, and Randy has acked it
> so I'm going to pull it into our XFS top-of-tree.  I'll
> hold off sending yet another pull request to Linus for
> now.  Thanks for addressing it quickly.
> 
> 					-Alex

Hi Alex,
Dave's patch is now needed in Linus's mainline kernel tree...


> > /me hates gcc's warning inconsistencies with a passion.
> > 
> >> e.g.:
> >> 
> >> In file included from linux-next-20091216/include/trace/ftrace.h:398,
> >>                  from linux-next-20091216/include/trace/define_trace.h:69,
> >>                  from linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.h:1369,
> >>                  from linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.c:75:
> >> linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h: In function
> >> 'ftrace_raw_output_id_xfs_iomap_enter': linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h:830:
> >> warning: format '%llx' expects type 'long long unsigned int', but argument 12 has type
> >> 'xfs_fsblock_t'  
> > 
> > Patch that should fix this below.
> > 
> > Cheers,
> > 
> > Dave.


---
~Randy

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-01-08 17:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 21:26 [GIT PULL] XFS update for 2.6.33-rc1 Alex Elder
2009-12-16 21:55 ` Randy Dunlap
2009-12-17  0:20   ` Dave Chinner
2009-12-17  1:56     ` Randy Dunlap
2009-12-17  3:41     ` Alex Elder
2010-01-08 17:44       ` Randy Dunlap [this message]
2010-01-08 18:09         ` Alex Elder
  -- strict thread matches above, loose matches on Subject: below --
2009-12-15 15:01 Alex Elder
2009-12-10 22:19 Alex Elder
2009-12-11  6:30 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100108094428.ff03c720.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=aelder@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox