From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH, updated] xfs: Ensure we force all busy extents in range to disk
Date: Sat, 9 Jan 2010 14:35:14 -0500 [thread overview]
Message-ID: <20100109193514.GA12372@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A693C@cf--amer001e--3.americas.sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> TRACE_EVENT(xfs_alloc_busysearch,
> TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
> - xfs_extlen_t len, int found),
> - TP_ARGS(mp, agno, agbno, len, found),
> + xfs_extlen_t len, int found, xfs_lsn_t lsn),
> + TP_ARGS(mp, agno, agbno, len, found, lsn),
The found argument to this tracepoint can be dropped - with the new loop
style it doesn't work anymore, and a non-zero lsn provides the same
information.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-09 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 2:39 [PATCH] XFS: Don't flush stale inodes Dave Chinner
2010-01-02 12:00 ` Christoph Hellwig
2010-01-02 12:14 ` Dave Chinner
2010-01-02 12:24 ` Dave Chinner
2010-01-02 13:17 ` Christoph Hellwig
2010-01-02 13:39 ` Dave Chinner
2010-01-08 20:59 ` Alex Elder
2010-01-08 23:14 ` [PATCH v2] xfs: " Alex Elder
2010-01-09 0:09 ` Dave Chinner
2010-01-09 16:22 ` Alex Elder
2010-01-09 22:39 ` Dave Chinner
2010-01-10 16:43 ` Alex Elder
2010-01-09 18:10 ` [PATCH, updated] xfs: Ensure we force all busy extents in range to disk Alex Elder
2010-01-09 19:35 ` Christoph Hellwig [this message]
2010-01-10 18:28 ` [PATCH, updated] xfs: Ensure we force all busy extents inrange " Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100109193514.GA12372@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox