From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: 219: ignore duplicates reported by repquota
Date: Sun, 10 Jan 2010 16:18:21 -0500 [thread overview]
Message-ID: <20100110211821.GA28166@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6942@cf--amer001e--3.americas.sgi.com>
On Sun, Jan 10, 2010 at 01:26:32PM -0600, Alex Elder wrote:
> (Re-sending; I misaddressed it the first time.)
>
> Arrange to ignore duplicate entries reported by the repquota command.
> This can happen if an id is used more than once (such as when two user
> names are assigned the same uid).
>
> Do this here by simply dropping any reported entries whose id number
> has already been seen in the output.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
>
> ---
> 219 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: b/219
> ===================================================================
> --- a/219
> +++ b/219
> @@ -85,7 +85,8 @@ test_accounting()
> $here/src/lstat64 $file | head -3 | filter_scratch
> done
>
> - repquota -$type -s -n $SCRATCH_MNT | grep -v "^#0" | filter_scratch
> + repquota -$type -s -n $SCRATCH_MNT | grep -v "^#0" | filter_scratch |
> + awk '/^#/ { if (! seen[$1]) { seen[$1]++; next; } } { print }'
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-10 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 19:26 [PATCH 2/2] xfstests: 219: ignore duplicates reported by repquota Alex Elder
2010-01-10 21:18 ` Christoph Hellwig [this message]
2010-01-29 5:09 ` Eric Sandeen
2010-01-30 10:30 ` Christoph Hellwig
2010-01-30 16:09 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110211821.GA28166@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox