From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix stale inode flush avoidance
Date: Mon, 11 Jan 2010 16:47:33 -0500 [thread overview]
Message-ID: <20100111214733.GA10278@infradead.org> (raw)
In-Reply-To: <1263210321-21068-1-git-send-email-david@fromorbit.com>
On Mon, Jan 11, 2010 at 10:45:21PM +1100, Dave Chinner wrote:
> When reclaiming stale inodes, we need to guarantee that inodes are
> unpinned before returning with a "clean" status. If we don't we can
> reclaim inodes that are pinned, leading to use after free in the
> transaction subsystem as transactions complete.
Looks good. Per discussion this morning the clean check might not be
good enough for delwri buffers either, but as let's leave that for the
more throughout redo of the inode buffer flushing.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-11 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 11:45 [PATCH] xfs: fix stale inode flush avoidance Dave Chinner
2010-01-11 21:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111214733.GA10278@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox