From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfsqa: add simple xfs_fsr test
Date: Tue, 12 Jan 2010 04:50:17 -0500 [thread overview]
Message-ID: <20100112095017.GC20017@infradead.org> (raw)
In-Reply-To: <1263271269-18997-5-git-send-email-david@fromorbit.com>
On Tue, Jan 12, 2010 at 03:41:09PM +1100, Dave Chinner wrote:
> We have very little fsr test coverage in the test suite right now.
> 042 is the only test that runs it, and it only defragments a single
> file.
>
> Improve the coverage by simply running xfs_fsr of the test
> filesystem. This gives xfs_fsr a wide variety of inodes to try to
> defragment. A simple test like this would have tripped over the
> attr2 fork offset problems in the swap extents ioctl long ago
> thanks to the varied nature of inodes the test suite leaves around
> in this filesystem.
Looks good,
and having it after 200+ testcases also means it should have at least a
bit of work to do.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-12 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 4:41 [PATCH 0/4] xfsqa: make some tests work again, add xfs_fsr test Dave Chinner
2010-01-12 4:41 ` [PATCH 1/4] xfsqa: filter the fsstress seed output in 104 Dave Chinner
2010-01-12 9:31 ` Christoph Hellwig
2010-01-12 4:41 ` [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again Dave Chinner
2010-01-12 10:00 ` Christoph Hellwig
2010-01-12 11:51 ` Dave Chinner
2010-01-12 4:41 ` [PATCH 3/4] xfsqa: filter log size in 206 Dave Chinner
2010-01-12 9:47 ` Christoph Hellwig
2010-01-12 4:41 ` [PATCH 4/4] xfsqa: add simple xfs_fsr test Dave Chinner
2010-01-12 9:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112095017.GC20017@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox