From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again
Date: Tue, 12 Jan 2010 22:51:17 +1100 [thread overview]
Message-ID: <20100112115117.GC17483@discord.disaster> (raw)
In-Reply-To: <20100112100031.GA8749@infradead.org>
On Tue, Jan 12, 2010 at 05:00:31AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 03:41:07PM +1100, Dave Chinner wrote:
> > Loop devices are now created and destroyed on demand, and
> > the existing hacks to do this no longer work. Remove them.
>
> Just noticed that I had not been running this test at all for a long
> time as it doesn't work with external logs.
>
> Seems like the current code indeed fails reliably for me and this
> patch fixes it.
>
> The only problem is that the loop device autodestruct features is only
> available since Linux 2.6.25 and also needs a recent util-linux. Is
> this old enough to simply go with the auto destruct version, or do
> we need to support either one?
>
> What about the patch below? This adds the -d argument to the umount
> calls for the loop images, which destroys the loop images in older
> kernels and is a no-op for modern kernels that have the loop
> auto-destruct feature:
Yes, that looks like a better way to solve the problem.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-12 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 4:41 [PATCH 0/4] xfsqa: make some tests work again, add xfs_fsr test Dave Chinner
2010-01-12 4:41 ` [PATCH 1/4] xfsqa: filter the fsstress seed output in 104 Dave Chinner
2010-01-12 9:31 ` Christoph Hellwig
2010-01-12 4:41 ` [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again Dave Chinner
2010-01-12 10:00 ` Christoph Hellwig
2010-01-12 11:51 ` Dave Chinner [this message]
2010-01-12 4:41 ` [PATCH 3/4] xfsqa: filter log size in 206 Dave Chinner
2010-01-12 9:47 ` Christoph Hellwig
2010-01-12 4:41 ` [PATCH 4/4] xfsqa: add simple xfs_fsr test Dave Chinner
2010-01-12 9:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112115117.GC17483@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox