From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] xfstests: test quota log replay in 087
Date: Tue, 12 Jan 2010 23:02:56 +1100 [thread overview]
Message-ID: <20100112120256.GD17483@discord.disaster> (raw)
In-Reply-To: <20100110212619.GA30907@infradead.org>
On Sun, Jan 10, 2010 at 04:26:19PM -0500, Christoph Hellwig wrote:
> By mounting the filesystem with quotas enabled in 087 we exercise the
> replay of the quota log items in this tests, which we otherwise don't
> test in xfstests. OSS bugzilla #855 is an example of something caught
> by this.
>
> Does this look okay, or should I add a duplicate of
> 087 with quotas enabled instead?
I think having 087 cover quotas as well is fine. Adding a separate
test just for quotas doesn't provide any extra coverage compared to
this patch.
> @@ -98,7 +100,7 @@ do
>
> # mount the FS
> _echofull "mount"
> - if ! _scratch_mount >>$seq.full 2>&1; then
> + if ! _scratch_mount -o uquota >>$seq.full 2>&1; then
My only question is whether this will work if uquota is set up as a
global option. I haven't looked into it yet, but there appears to be
several different ways that uquota is specified in other tests:
052:_qmount_option uquota
108:export MOUNT_OPTIONS="-ouquota"
116:mount -o uquota $SCRATCH_DEV $SCRATCH_MNT
220:_scratch_mount -o uquota
Some consistency would be nice, but I don't think it's a problem
for this patch right now.
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-12 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 21:26 [PATCH, RFC] xfstests: test quota log replay in 087 Christoph Hellwig
2010-01-12 12:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112120256.GD17483@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox