From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0E0qxi2205762 for ; Wed, 13 Jan 2010 18:52:59 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DEE8E16438A for ; Wed, 13 Jan 2010 16:53:54 -0800 (PST) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id UvQFidTecH3d8V0G for ; Wed, 13 Jan 2010 16:53:54 -0800 (PST) Date: Thu, 14 Jan 2010 11:53:51 +1100 From: Dave Chinner Subject: Re: [PATCH 2/3] xfs: clean up error handling in xfs_trans_dqresv Message-ID: <20100114005351.GU17483@discord.disaster> References: <20100113220547.846700560@bombadil.infradead.org> <20100113220602.928911019@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100113220602.928911019@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Jan 13, 2010 at 05:05:49PM -0500, Christoph Hellwig wrote: > Move the error code selection after the goto label and fold the > xfs_quota_error helper into it. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs