From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: xfs_swap_extents needs to handle dynamic fork offsets
Date: Thu, 14 Jan 2010 01:35:10 -0500 [thread overview]
Message-ID: <20100114063510.GA20445@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6965@cf--amer001e--3.americas.sgi.com>
On Wed, Jan 13, 2010 at 04:32:12PM -0600, Alex Elder wrote:
> Christoph Hellwig wrote:
> >> + TP_printk("dev %d:%d %s inode 0x%llx, %s format, num_extents %d, "
> >> + "Max in-fork extents %d, broot size %d, fork offset %d",
> >
> > It would be nice to keep the
> >
> > "dev %d:%d ino 0x%llx"
> >
> > prefix as a convention so that all trace records are similar at their
> > beginning.
>
> Perhaps:
> + TP_printk("dev %d:%d inode 0x%llx (%s), %s format, num_extents %d, "
> ^
> +--- symbolic entry->which
Sounds fine, except s/inode/ino/ above to stay consistant.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-14 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 5:01 [PATCH] xfs: xfs_swap_extents needs to handle dynamic fork offsets Dave Chinner
2010-01-12 13:09 ` Christoph Hellwig
2010-01-13 22:32 ` Alex Elder
2010-01-13 23:03 ` Dave Chinner
2010-01-14 6:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114063510.GA20445@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox