From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: implement quota warnings via netlink
Date: Thu, 14 Jan 2010 01:42:28 -0500 [thread overview]
Message-ID: <20100114064228.GA29458@infradead.org> (raw)
In-Reply-To: <20100114011948.GV17483@discord.disaster>
On Thu, Jan 14, 2010 at 12:19:48PM +1100, Dave Chinner wrote:
> > Tested by running the quota_nld daemon while running the xfstest quota
> > tests and observing the warnings. I'll see how I can get a more formal
> > testcase for it written.
>
> Sounds like it needs something similar to the dmapi event listeners
> we use for testing that the dmapi events are generated correctly....
That's what quota_nld does, just need to tie it up properly.
> This appears to send "over block quota" warnings even when
> the error is caused by the number of inodes going over limit.
> For inode count warnings we should be sending QUOTA_NL_IHARDWARN or
> QUOTA_NL_ISOFTWARN. That could be easily done if the "hard"
> parameter is changed to the type of warning which is set up
> in the calling function.
>
> We could probably even return the grace limit expired versions
> as well when over the soft limits with a slight change to the
> soft limit warning logic as well...
Indeed, I did copy this from gfs2 which only does the block quotas
and no differciated soft warnings. I'll respin it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-14 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 22:05 [PATCH 0/3] small quota updates for 2.6.34 Christoph Hellwig
2010-01-13 22:05 ` [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC Christoph Hellwig
2010-01-14 0:47 ` Dave Chinner
2010-01-14 18:59 ` Alex Elder
2010-01-13 22:05 ` [PATCH 2/3] xfs: clean up error handling in xfs_trans_dqresv Christoph Hellwig
2010-01-14 0:53 ` Dave Chinner
2010-01-13 22:05 ` [PATCH 3/3] xfs: implement quota warnings via netlink Christoph Hellwig
2010-01-14 1:19 ` Dave Chinner
2010-01-14 6:42 ` Christoph Hellwig [this message]
2010-01-17 22:36 ` [PATCH 3/3 v2] " Christoph Hellwig
2010-01-18 11:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114064228.GA29458@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox