From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: Make the compile output cleaner V2
Date: Thu, 14 Jan 2010 21:11:28 +1100 [thread overview]
Message-ID: <20100114101128.GX17483@discord.disaster> (raw)
In-Reply-To: <20100114065123.GA32559@infradead.org>
On Thu, Jan 14, 2010 at 01:51:23AM -0500, Christoph Hellwig wrote:
> On Thu, Jan 14, 2010 at 09:30:01AM +1100, Dave Chinner wrote:
> > > > include/builddefs include/platform_defs.h
> > >
> > > > distclean: clean
> > > > - rm -f $(LDIRT)
> > > > + $(Q)rm -f $(DISTDIRT)
> > >
> > > What does this have to do with the rest?
> >
> > That's the "make clean doesn't cause configure to run again" fix.
>
> Which is not related to the clean output build system..
>
> I'm pretty sure we did this intentionally, but I'm open to a discussion
> about changing it.
It seems completely spurious to me - normal practice is to blow away
the config on a distclean, not a plain clean. And seeing as the
patch is about removing noise during the normal build, I figured
this qualified as a bug causing noise.
I can separate it out into another patch, but I'd really prefer that
make clean doesn't result in running configure again. Especially
considering the build dependencies are very broken so the only way
to guarantee a build catches all changes is to do 'make clean;
make'.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-14 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 10:03 [PATCH] xfsprogs: Make the compile output cleaner V2 Dave Chinner
2010-01-13 14:50 ` Eric Sandeen
2010-01-13 22:08 ` Christoph Hellwig
2010-01-13 22:30 ` Dave Chinner
2010-01-14 6:51 ` Christoph Hellwig
2010-01-14 10:11 ` Dave Chinner [this message]
2010-01-17 11:55 ` Christoph Hellwig
2010-01-13 22:43 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114101128.GX17483@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox