From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/10] Perag lookup rework
Date: Fri, 15 Jan 2010 09:37:25 +1100 [thread overview]
Message-ID: <20100114223725.GY17483@discord.disaster> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A696E@cf--amer001e--3.americas.sgi.com>
On Thu, Jan 14, 2010 at 12:42:12PM -0600, Alex Elder wrote:
> Dave Chinner wrote:
> > This is the previous set of patches all put together in the one series
> > for the current xfs-dev tree.
> >
> > Patch 10 is a new patch - it embeds the busy extent list into the perag
> > structure rather than leaving as a separate allocation.
>
> All 10 patches look good. I am adding the following descriptions
> to these patches which lacked them:
>
> http://patchwork.xfs.org/patch/429/
> [03/10] XFS: Convert filestreams code to use per-ag get/put routines
>
> Description:
> Use xfs_perag_get() and xfs_perag_put() in the filestreams code.
I'd consier that redundant and therefore unnecssary. I don't put
a descriptio in if the subject line describes the patch
sufficiently. It seems to be a pretty common practise, actually.
> http://patchwork.xfs.org/patch/417/
> [09/10] xfs: handle ENOMEM correctly during initialisation of perag structures
>
> Description:
> Add proper error handling in case an error occurs while initializing
> new perag structures for a mount point. The mount structure is
> restored to its previous state by deleting and freeing any perag
> structures added during the call.
That describes what the code does, which I'd also consider
redundant... ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-14 22:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 11:47 [PATCH 0/10] Perag lookup rework Dave Chinner
2010-01-11 11:47 ` [PATCH 01/10] XFS: rename xfs_get_perag Dave Chinner
2010-01-11 11:47 ` [PATCH 02/10] XFS: Don't directly reference m_perag in allocation code Dave Chinner
2010-01-11 11:47 ` [PATCH 03/10] XFS: Convert filestreams code to use per-ag get/put routines Dave Chinner
2010-01-11 11:47 ` [PATCH 04/10] XFS: convert remaining direct references to m_perag Dave Chinner
2010-01-11 11:47 ` [PATCH 05/10] XFS: Replace per-ag array with a radix tree Dave Chinner
2010-01-11 11:47 ` [PATCH 06/10] XFS: Reference count per-ag structures Dave Chinner
2010-01-11 11:47 ` [PATCH 07/10] XFS: Add trace points for per-ag refcount debugging Dave Chinner
2010-01-11 11:47 ` [PATCH 08/10] XFS: Kill filestreams cache flush Dave Chinner
2010-01-11 11:47 ` [PATCH 09/10] xfs: handle ENOMEM correctly during initialisation of perag structures Dave Chinner
2010-01-11 11:47 ` [PATCH 10/10] xfs: embed the pagb_list array in the perag structure Dave Chinner
2010-01-11 22:33 ` [PATCH 0/10] Perag lookup rework Christoph Hellwig
2010-01-11 22:34 ` Christoph Hellwig
2010-01-14 18:42 ` Alex Elder
2010-01-14 22:37 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114223725.GY17483@discord.disaster \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox