From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] mkfs: get size of device properly
Date: Sun, 17 Jan 2010 06:40:36 -0500 [thread overview]
Message-ID: <20100117114036.GA7813@infradead.org> (raw)
In-Reply-To: <4B50F2F0.4050909@sandeen.net>
On Fri, Jan 15, 2010 at 04:57:52PM -0600, Eric Sandeen wrote:
> Ok, one more.
>
> I've been having too many problems w/ xfstests today to have run
> the last patch through xfstests but should have at least run
> 032. :(
>
> Anyway, last change wasn't valid to test the size of a device
> node; total brain fart. After this I'm testing the hell out
> of the next patch I send, I promise!
>
> --------
>
> Test device node size properly in check_overwrite, st_size
> is only valid for regular files.
The patch looks correct to me, but it also means we now open the device
twice in check_overwrite. We might aswell use it just once and keep the
fd for the blkid probe. Anyway, probably better to put this one in
ASAP, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Any chance you could create a xfstests regression test for this?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-17 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 22:57 [PATCH] mkfs: get size of device properly Eric Sandeen
2010-01-17 11:40 ` Christoph Hellwig [this message]
2010-01-17 15:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117114036.GA7813@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox