From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0HBpEA3009642 for ; Sun, 17 Jan 2010 05:51:14 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 42B481C57662 for ; Sun, 17 Jan 2010 03:52:13 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 8kZmYcWDYMuxoqra for ; Sun, 17 Jan 2010 03:52:13 -0800 (PST) Date: Sun, 17 Jan 2010 06:52:12 -0500 From: Christoph Hellwig Subject: Re: [PATCH 3/9] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs Message-ID: <20100117115212.GD10994@infradead.org> References: <1263463752-5052-1-git-send-email-david@fromorbit.com> <1263463752-5052-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1263463752-5052-4-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Thu, Jan 14, 2010 at 09:09:06PM +1100, Dave Chinner wrote: > When xfs_rtfind_forw() returns an error, the block is returned > uninitialised. xfs_rtfree_range() is not checking the error return, > so could be using an uninitialised block number for modifying bitmap > summary info. Looks good, (actually a merge of the kernel side fix that just went in) Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs