From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: Make the compile output cleaner V2
Date: Sun, 17 Jan 2010 06:55:15 -0500 [thread overview]
Message-ID: <20100117115515.GA16856@infradead.org> (raw)
In-Reply-To: <20100114101128.GX17483@discord.disaster>
On Thu, Jan 14, 2010 at 09:11:28PM +1100, Dave Chinner wrote:
> It seems completely spurious to me - normal practice is to blow away
> the config on a distclean, not a plain clean. And seeing as the
> patch is about removing noise during the normal build, I figured
> this qualified as a bug causing noise.
>
> I can separate it out into another patch, but I'd really prefer that
> make clean doesn't result in running configure again. Especially
> considering the build dependencies are very broken so the only way
> to guarantee a build catches all changes is to do 'make clean;
> make'.
Looking at various other packages it seems like configure output
usually survives make clean indeed. With that I agree with the change,
but it really should be a separate patch.
Reviewed-by: Christoph Hellwig <hch@lst.de>
For this one without that change, and I'll also approve the make clean
change when you send it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-17 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 10:03 [PATCH] xfsprogs: Make the compile output cleaner V2 Dave Chinner
2010-01-13 14:50 ` Eric Sandeen
2010-01-13 22:08 ` Christoph Hellwig
2010-01-13 22:30 ` Dave Chinner
2010-01-14 6:51 ` Christoph Hellwig
2010-01-14 10:11 ` Dave Chinner
2010-01-17 11:55 ` Christoph Hellwig [this message]
2010-01-13 22:43 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117115515.GA16856@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox