From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J1JTWg145256 for ; Mon, 18 Jan 2010 19:19:29 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AC95811F8B0B for ; Mon, 18 Jan 2010 17:08:06 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id hSBweH7FC0PosJlF for ; Mon, 18 Jan 2010 17:08:06 -0800 (PST) Date: Tue, 19 Jan 2010 12:08:03 +1100 From: Dave Chinner Subject: Re: [PATCH] xfsteststs: get fsstress DIO working on non-xfs filesystems Message-ID: <20100119010803.GL7264@discord.disaster> References: <4B54C8AB.6080607@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4B54C8AB.6080607@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Mon, Jan 18, 2010 at 02:46:35PM -0600, Eric Sandeen wrote: > Pretty sure all DIO IO fails in fsstress today since XFS_IOC_DIOINFO > fails. If so, rather than just bailing out on the op, assign > some sane default DIO parameters. > > This falls down for 4k sector devices but not really sure how to get > the underlying sector size easily from here; I think we can live > with this for now. ioctl(fd, BLKSSZGET, ...) perhaps? And then if that fails, just hard code it? > hch suggested moving XFS_IOC_DIOINFO up higher in the vfs, that's > probably a good idea in the long run. Yeah, that makes sense to do. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs