From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks
Date: Tue, 19 Jan 2010 04:19:07 -0500 [thread overview]
Message-ID: <20100119091907.GG29269@infradead.org> (raw)
In-Reply-To: <1263891792-30952-4-git-send-email-david@fromorbit.com>
On Tue, Jan 19, 2010 at 08:03:12PM +1100, Dave Chinner wrote:
> Test 017 is consistently failing now because the xfs_check uses
> buffered IO to read the block device and 017 runs xfs_check ona
> remount,ro filesystem. Hence the block device cache is never
> invalidated (the unmount path does this) and so xfs_check can see
> stale blocks from previous invocations instead of what is really on
> disk at the time it is run.
>
> Manually trash the page cache before running xfs_check to ensure
> that the blockdev cache is clean and we don't get false errors
> from stale blocks.
I don't think this is correct. We need to provide this synchronization
from kernel land. IIRC Al even has a patch towards this in his tree,
can't point you to it to try it because his tree on kernel.org seems
messed up right now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-19 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 9:03 [PATCH 0/3] xfsqa: Fix various test-suite related failures Dave Chinner
2010-01-19 9:03 ` [PATCH 1/3] xfsqa: update 214 golden output Dave Chinner
2010-01-19 9:17 ` Christoph Hellwig
2010-01-19 9:03 ` [PATCH 2/3] xfsqa: Fix signal usage in aio-dio test code Dave Chinner
2010-01-19 9:18 ` Christoph Hellwig
2010-01-19 9:03 ` [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks Dave Chinner
2010-01-19 9:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119091907.GG29269@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox