From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi()
Date: Tue, 19 Jan 2010 04:22:40 -0500 [thread overview]
Message-ID: <20100119092240.GC1784@infradead.org> (raw)
In-Reply-To: <1263861711-13900-2-git-send-email-david@fromorbit.com>
On Tue, Jan 19, 2010 at 11:41:50AM +1100, Dave Chinner wrote:
> Initialise the xfs_bmalloca_t structure to zero to avoid uninitialised
> variable warnings. This is done by zeroing the arg structure rather than
> using the uninitialised_var() trick so we know for certain that the
> structure is correctly initialised as xfs_bmapi is a very complex
> function and it is difficult to prove warnings are spurious.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:41 [PATCH 0/2] xfs: warning fixes needed for libxfs Dave Chinner
2010-01-19 0:41 ` [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi() Dave Chinner
2010-01-19 9:22 ` Christoph Hellwig [this message]
2010-01-19 0:41 ` [PATCH 2/2] xfs: rearrange xfs_mod_sb() to avoid array subscript warning Dave Chinner
2010-01-19 9:23 ` Christoph Hellwig
2010-01-19 11:11 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119092240.GC1784@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox