From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J9LeYt180310 for ; Tue, 19 Jan 2010 03:21:41 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 18DA1F1ECB0 for ; Tue, 19 Jan 2010 01:22:40 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id aEZiLXfuxF3jX3bn for ; Tue, 19 Jan 2010 01:22:40 -0800 (PST) Date: Tue, 19 Jan 2010 04:22:40 -0500 From: Christoph Hellwig Subject: Re: [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi() Message-ID: <20100119092240.GC1784@infradead.org> References: <1263861711-13900-1-git-send-email-david@fromorbit.com> <1263861711-13900-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1263861711-13900-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jan 19, 2010 at 11:41:50AM +1100, Dave Chinner wrote: > Initialise the xfs_bmalloca_t structure to zero to avoid uninitialised > variable warnings. This is done by zeroing the arg structure rather than > using the uninitialised_var() trick so we know for certain that the > structure is correctly initialised as xfs_bmapi is a very complex > function and it is difficult to prove warnings are spurious. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs