From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J9MKFO180351 for ; Tue, 19 Jan 2010 03:22:20 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6DDC51733BD for ; Tue, 19 Jan 2010 01:23:20 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 7wH2qyGl1tE895Tr for ; Tue, 19 Jan 2010 01:23:20 -0800 (PST) Date: Tue, 19 Jan 2010 04:23:20 -0500 From: Christoph Hellwig Subject: Re: [PATCH 2/2] xfs: rearrange xfs_mod_sb() to avoid array subscript warning Message-ID: <20100119092320.GD1784@infradead.org> References: <1263861711-13900-1-git-send-email-david@fromorbit.com> <1263861711-13900-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1263861711-13900-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jan 19, 2010 at 11:41:51AM +1100, Dave Chinner wrote: > gcc warns of an array subscript out of bounds in xfs_mod_sb(). > The code is written in such a way that if the array subscript is > out of bounds, then it will assert fail. Rearrange the code to > avoid the bounds check warning. Does it avoid the warning also for non-debug builds where the assert goes away? Anyway, the reordering is correct, so: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs