From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J9Q272180576 for ; Tue, 19 Jan 2010 03:26:02 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 89F651735B6 for ; Tue, 19 Jan 2010 01:27:02 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id En1R3fKlfq9yDJMa for ; Tue, 19 Jan 2010 01:27:02 -0800 (PST) Date: Tue, 19 Jan 2010 04:27:02 -0500 From: Christoph Hellwig Subject: Re: [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness Message-ID: <20100119092701.GE7168@infradead.org> References: <1263861026-13448-1-git-send-email-david@fromorbit.com> <1263861026-13448-6-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1263861026-13448-6-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jan 19, 2010 at 11:30:23AM +1100, Dave Chinner wrote: > xfs_buf_iomove() uses xfs_caddr_t as it's parameter types, but it doesn't > care about the signedness of the variables as it is just copying the > data. Change the prototype to use void * so that we don't get sign > warnings at call sites. Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs