From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J9SdHM180722 for ; Tue, 19 Jan 2010 03:28:40 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0E86D1C5DFA7 for ; Tue, 19 Jan 2010 01:29:39 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id FZTeTMkPy5GXemJ9 for ; Tue, 19 Jan 2010 01:29:39 -0800 (PST) Date: Tue, 19 Jan 2010 04:29:39 -0500 From: Christoph Hellwig Subject: Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again Message-ID: <20100119092939.GG7168@infradead.org> References: <1263861026-13448-1-git-send-email-david@fromorbit.com> <1263861026-13448-9-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1263861026-13448-9-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jan 19, 2010 at 11:30:26AM +1100, Dave Chinner wrote: > The -fno-unsigned-char directive has no effect anymore as the > XFs build is clean. However, the kernel build hides pointer sign > differences so turn that back on so that we can clean up all the > mismatches prior to a userspace code resync. Not so happy about turning the warning on so we have local compiler warning differences from the rest of the kernel again, but it's not that bad, so Reviewed-by: Christoph Hellwig > index 6f26875..9f7c001 100644 > --- a/fs/xfs/xfs_vnodeops.c > +++ b/fs/xfs/xfs_vnodeops.c > @@ -2199,7 +2199,8 @@ xfs_symlink( > if (DM_EVENT_ENABLED(dp, DM_EVENT_SYMLINK)) { > error = XFS_SEND_NAMESP(mp, DM_EVENT_SYMLINK, dp, > DM_RIGHT_NULL, NULL, DM_RIGHT_NULL, > - link_name->name, target_path, 0, 0, 0); > + link_name->name, > + (unsigned char *)target_path, 0, 0, 0); > if (error) > return error; > } > @@ -2395,7 +2396,8 @@ std_return: > dp, DM_RIGHT_NULL, > error ? NULL : ip, > DM_RIGHT_NULL, link_name->name, > - target_path, 0, error, 0); > + (unsigned char *)target_path, > + 0, error, 0); These changes are nowhere mentioned in the changelog. And they probably belong into the patch changing the dmapi events to take unsigned chars. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs