From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db
Date: Tue, 19 Jan 2010 04:34:40 -0500 [thread overview]
Message-ID: <20100119093440.GA15482@infradead.org> (raw)
In-Reply-To: <1263861413-13729-4-git-send-email-david@fromorbit.com>
On Tue, Jan 19, 2010 at 11:36:49AM +1100, Dave Chinner wrote:
> Three warnings, none harmful - one dir2 name sign warning and
> two cases where gcc can't work out if a variable is initialised
> correctly in a child function or not.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> db/check.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/db/check.c b/db/check.c
> index 7620d9c..f94a16b 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -2317,7 +2317,7 @@ process_data_dir_v2(
> tag_err += be16_to_cpu(*tagp) != (char *)dep - (char *)data;
> addr = xfs_dir2_db_off_to_dataptr(mp, db,
> (char *)dep - (char *)data);
> - xname.name = (char *)dep->name;
> + xname.name = (uchar_t *)dep->name;
Aren't hese now both unsigned after the kernel changes are sycned over?
And btw, please also avoid uchar_t in xfsprogs, it will be gone with
next full libxfs resync.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:36 [PATCH 0/7] xfsprogs: Fix build warnings V3 Dave Chinner
2010-01-19 0:36 ` [PATCH 1/7] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs Dave Chinner
2010-01-19 0:36 ` [PATCH 2/7] xfsprogs: fix warning in adfs superblock probe Dave Chinner
2010-01-19 0:36 ` [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db Dave Chinner
2010-01-19 9:21 ` Christoph Hellwig
2010-01-19 9:34 ` Christoph Hellwig [this message]
2010-01-19 0:36 ` [PATCH 4/7] xfsprogs: fix trivial warnings in xfs_fsr Dave Chinner
2010-01-19 0:36 ` [PATCH 5/7] xfsprogs: fix print format warnings in xfs_io Dave Chinner
2010-01-19 0:36 ` [PATCH 6/7] xfsprogs: fix sign warning in mkfs directory code Dave Chinner
2010-01-19 0:36 ` [PATCH 7/7] xfsprogs: fix build warnings in repair V2 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119093440.GA15482@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox