From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfsprogs: Do not remove configure information on clean
Date: Tue, 19 Jan 2010 22:09:26 +1100 [thread overview]
Message-ID: <20100119110926.GA14035@discord.disaster> (raw)
In-Reply-To: <20100119091531.GA29269@infradead.org>
On Tue, Jan 19, 2010 at 04:15:31AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 19, 2010 at 11:33:05AM +1100, Dave Chinner wrote:
> > ??ormal packaging practice is to remove the configure scripts
> > on a 'make distclean' so that a 'make clean' doesn't result in
> > having to rerun the configure scripts. Change the clean targets
> > in the top level makefile to only clear configure files on
> > a distclean.
> >
> > Signed-off-by: Dave Chinner <david@fromorbit.com>
> > ---
> > Makefile | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 2d394e4..a7615ca 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -15,7 +15,7 @@ SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
> > CONFIGURE = aclocal.m4 configure config.guess config.sub install-sh ltmain.sh
> > LSRCFILES = configure.in release.sh README VERSION $(CONFIGURE)
> >
> > -LDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
> > +DISTDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
> > built .census install.* install-dev.* *.gz autom4te.cache/* libtool \
> > include/builddefs include/platform_defs.h
>
> But this isn't all configure stuff, is it? install.* install-dev.* *.gz
> is from the install process, and .dep is part of make dep.
Hmm - I never do make installs - I always build packages because I
build on a different machine to the ones I test one. I'll check it
out, but I've never seen install* files generated in the top level.
For the *.gz files, the tarballs are generated by "make dist",
so shouldn't they be removed by "make distclean"?
As to depenencies, we have no "make dep" target, there doesn't
appear to be any makefile gunk to generate them, and the
dependencies are completely busted. That's on my list to fix.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:33 [PATCH 0/2] xfsprogs: Cleaner build output Dave Chinner
2010-01-19 0:33 ` [PATCH 1/2] xfsprogs: Do not remove configure information on clean Dave Chinner
2010-01-19 9:15 ` Christoph Hellwig
2010-01-19 11:09 ` Dave Chinner [this message]
2010-01-19 0:33 ` [PATCH 2/2] xfsprogs: Make the compile output cleaner V3 Dave Chinner
2010-01-19 9:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119110926.GA14035@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox