From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0JB8V1N187284 for ; Tue, 19 Jan 2010 05:08:32 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5E02815173ED for ; Tue, 19 Jan 2010 03:09:29 -0800 (PST) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id RBeA0dNdJpIz90IE for ; Tue, 19 Jan 2010 03:09:29 -0800 (PST) Date: Tue, 19 Jan 2010 22:09:26 +1100 From: Dave Chinner Subject: Re: [PATCH 1/2] xfsprogs: Do not remove configure information on clean Message-ID: <20100119110926.GA14035@discord.disaster> References: <1263861186-13589-1-git-send-email-david@fromorbit.com> <1263861186-13589-2-git-send-email-david@fromorbit.com> <20100119091531.GA29269@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100119091531.GA29269@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Jan 19, 2010 at 04:15:31AM -0500, Christoph Hellwig wrote: > On Tue, Jan 19, 2010 at 11:33:05AM +1100, Dave Chinner wrote: > > ??ormal packaging practice is to remove the configure scripts > > on a 'make distclean' so that a 'make clean' doesn't result in > > having to rerun the configure scripts. Change the clean targets > > in the top level makefile to only clear configure files on > > a distclean. > > > > Signed-off-by: Dave Chinner > > --- > > Makefile | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 2d394e4..a7615ca 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -15,7 +15,7 @@ SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz > > CONFIGURE = aclocal.m4 configure config.guess config.sub install-sh ltmain.sh > > LSRCFILES = configure.in release.sh README VERSION $(CONFIGURE) > > > > -LDIRT = config.log .dep config.status config.cache confdefs.h conftest* \ > > +DISTDIRT = config.log .dep config.status config.cache confdefs.h conftest* \ > > built .census install.* install-dev.* *.gz autom4te.cache/* libtool \ > > include/builddefs include/platform_defs.h > > But this isn't all configure stuff, is it? install.* install-dev.* *.gz > is from the install process, and .dep is part of make dep. Hmm - I never do make installs - I always build packages because I build on a different machine to the ones I test one. I'll check it out, but I've never seen install* files generated in the top level. For the *.gz files, the tarballs are generated by "make dist", so shouldn't they be removed by "make distclean"? As to depenencies, we have no "make dep" target, there doesn't appear to be any makefile gunk to generate them, and the dependencies are completely busted. That's on my list to fix. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs