From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again
Date: Tue, 19 Jan 2010 22:15:09 +1100 [thread overview]
Message-ID: <20100119111509.GC14035@discord.disaster> (raw)
In-Reply-To: <20100119092939.GG7168@infradead.org>
On Tue, Jan 19, 2010 at 04:29:39AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 19, 2010 at 11:30:26AM +1100, Dave Chinner wrote:
> > The -fno-unsigned-char directive has no effect anymore as the
> > XFs build is clean. However, the kernel build hides pointer sign
> > differences so turn that back on so that we can clean up all the
> > mismatches prior to a userspace code resync.
>
> Not so happy about turning the warning on so we have local compiler
> warning differences from the rest of the kernel again, but it's not
> that bad, so
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > index 6f26875..9f7c001 100644
> > --- a/fs/xfs/xfs_vnodeops.c
> > +++ b/fs/xfs/xfs_vnodeops.c
> > @@ -2199,7 +2199,8 @@ xfs_symlink(
> > if (DM_EVENT_ENABLED(dp, DM_EVENT_SYMLINK)) {
> > error = XFS_SEND_NAMESP(mp, DM_EVENT_SYMLINK, dp,
> > DM_RIGHT_NULL, NULL, DM_RIGHT_NULL,
> > - link_name->name, target_path, 0, 0, 0);
> > + link_name->name,
> > + (unsigned char *)target_path, 0, 0, 0);
> > if (error)
> > return error;
> > }
> > @@ -2395,7 +2396,8 @@ std_return:
> > dp, DM_RIGHT_NULL,
> > error ? NULL : ip,
> > DM_RIGHT_NULL, link_name->name,
> > - target_path, 0, error, 0);
> > + (unsigned char *)target_path,
> > + 0, error, 0);
>
> These changes are nowhere mentioned in the changelog. And they probably
> belong into the patch changing the dmapi events to take unsigned chars.
I though I fixed that. Oh well, I'll fix it up again....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-01-19 11:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:30 [PATCH 0/8] xfs: clean up pointer sign differences Dave Chinner
2010-01-19 0:30 ` [PATCH 1/8] xfs: directory names are unsigned Dave Chinner
2010-01-19 9:24 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 2/8] xfs: convert DM ops to use unsigned char names Dave Chinner
2010-01-19 9:25 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 3/8] xfs: convert dirnameops to " Dave Chinner
2010-01-19 9:25 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char Dave Chinner
2010-01-19 9:26 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness Dave Chinner
2010-01-19 9:27 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 6/8] xfs: convert attr to use unsigned names Dave Chinner
2010-01-19 9:32 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 7/8] xfs: clean up sign warnings in dir2 code Dave Chinner
2010-01-19 9:27 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 8/8] xfs: make compile warn about char sign mismatches again Dave Chinner
2010-01-19 9:29 ` Christoph Hellwig
2010-01-19 11:15 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119111509.GC14035@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox