From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] [PATCH] xfs: remove duplicate buffer flags
Date: Wed, 20 Jan 2010 10:12:30 +1100 [thread overview]
Message-ID: <20100119231230.GD14035@discord.disaster> (raw)
In-Reply-To: <20100119095654.708720933@bombadil.infradead.org>
On Tue, Jan 19, 2010 at 04:56:44AM -0500, Christoph Hellwig wrote:
> Currently we define aliases for the buffer flags in various namespaces,
> which only adds confusion. Remove all but the XBF_ flags to clean this
> up a bit.
>
> Note that we still abuse XFS_B_ASYNC/XBF_ASYNC for some non-buffer uses,
> but I'll clean that up later.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. This has been on my "things for a rainy day" list for
quite some time.
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 9:56 [PATCH 0/3] random cleanups for 2.6.34 Christoph Hellwig
2010-01-19 9:56 ` [PATCH 1/3] [PATCH] xfs: remove duplicate buffer flags Christoph Hellwig
2010-01-19 23:12 ` Dave Chinner [this message]
2010-01-19 9:56 ` [PATCH 2/3] xfs: kill XLOG_VEC_SET_TYPE Christoph Hellwig
2010-01-19 23:14 ` Dave Chinner
2010-01-19 9:56 ` [PATCH 3/3] xfs: cleanup up xfs_log_force calling conventions Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119231230.GD14035@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox