From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/8] xfstests: fix compile warnings in iopat.c
Date: Wed, 20 Jan 2010 03:31:40 -0500 [thread overview]
Message-ID: <20100120083140.GE6721@infradead.org> (raw)
In-Reply-To: <1263958688-435-6-git-send-email-david@fromorbit.com>
On Wed, Jan 20, 2010 at 02:38:05PM +1100, Dave Chinner wrote:
> Printf format warnings and return value warnings need fixing.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> ---
> src/iopat.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/iopat.c b/src/iopat.c
> index c06071f..f34de19 100644
> --- a/src/iopat.c
> +++ b/src/iopat.c
> @@ -47,12 +47,13 @@ int main(int argc, char **argv)
> read(fd, &x, 1048576);
> for (i = 0; i < 131072; i++) {
> if (x[i] != i) {
> - printf("error: %d %d %d\n",i,8*i,x[i]);
> + printf("error: %d %d %lld\n", i ,8 * i, (long long)x[i]);
> exit(1);
Instead of the casting we could also use the C99 macro for the uin64_t
format. But either way good enough for the tests,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-20 8:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 3:38 [PATCH 0/8] xfstests: fix compile warnings Dave Chinner
2010-01-20 3:38 ` [PATCH 1/8] xfstests: fix compile warning in doio.c Dave Chinner
2010-01-20 8:26 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 2/8] xfstests: fix bulkstat related compile warnings Dave Chinner
2010-01-20 8:26 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c Dave Chinner
2010-01-20 8:28 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 4/8] xfstests: fix printf format warnings in aio-stress.c Dave Chinner
2010-01-20 8:30 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 5/8] xfstests: fix compile warnings in iopat.c Dave Chinner
2010-01-20 8:31 ` Christoph Hellwig [this message]
2010-01-20 3:38 ` [PATCH 6/8] xfstests: fix printf format warnings in looptest.c Dave Chinner
2010-01-20 8:32 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 7/8] xfstests: fix printf warnings in locktest.c Dave Chinner
2010-01-20 8:32 ` Christoph Hellwig
2010-01-20 3:38 ` [PATCH 8/8] xfstests: don't redefine _GNU_SOURCE in aio tests Dave Chinner
2010-01-20 8:33 ` Christoph Hellwig
2010-01-20 22:02 ` [PATCH 0/8] xfstests: fix compile warnings Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120083140.GE6721@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox