From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH] xfstests: simplify build of preallo_rw_pattern_reader/writer
Date: Thu, 21 Jan 2010 06:32:50 -0500 [thread overview]
Message-ID: <20100121113250.GA3580@infradead.org> (raw)
Instead of having complicated build system hacks just create two two-line
source files defining READ/WRITE and including iopat.c
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/src/Makefile
===================================================================
--- xfstests-dev.orig/src/Makefile 2010-01-21 11:24:43.000000000 +0000
+++ xfstests-dev/src/Makefile 2010-01-21 11:26:09.000000000 +0000
@@ -51,19 +51,9 @@ LDIRT = $(TARGETS)
default: $(TARGETS) $(SUBDIRS)
-PREALLO_TARGETS = preallo_rw_pattern_reader preallo_rw_pattern_writer
-
include $(BUILDRULES)
-preallo_rw_pattern_reader:
- @echo " [CC] $@"
- $(Q)$(LTLINK) iopat.c -DREAD -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS) $(LIBTEST)
-
-preallo_rw_pattern_writer:
- @echo " [CC] $@"
- $(Q)$(LTLINK) iopat.c -DWRITE -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS) $(LIBTEST)
-
-$(filter-out $(PREALLO_TARGETS), $(TARGETS)): $(LIBTEST)
+$(TARGETS): $(LIBTEST)
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS) $(LIBTEST)
Index: xfstests-dev/src/preallo_rw_pattern_reader.c
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/src/preallo_rw_pattern_reader.c 2010-01-21 11:24:19.000000000 +0000
@@ -0,0 +1,2 @@
+#define READ
+#include "iopat.c"
Index: xfstests-dev/src/preallo_rw_pattern_writer.c
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/src/preallo_rw_pattern_writer.c 2010-01-21 11:24:30.000000000 +0000
@@ -0,0 +1,2 @@
+#define WRITE
+#include "iopat.c"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-01-21 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 11:32 Christoph Hellwig [this message]
2010-01-21 14:00 ` [PATCH] xfstests: simplify build of preallo_rw_pattern_reader/writer Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121113250.GA3580@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox