From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix format string warnings in locktest.c
Date: Thu, 21 Jan 2010 12:32:37 -0500 [thread overview]
Message-ID: <20100121173237.GA25322@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AE@cf--amer001e--3.americas.sgi.com>
On Thu, Jan 21, 2010 at 10:34:12AM -0600, Alex Elder wrote:
> Alex Elder wrote:
> > Christoph Hellwig wrote:
> >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Looks good.
> >
> > Reviewed-by: Alex Elder <aelder@sgi.com>
>
> By the way, the content of this patch is already incorporated
> in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c".
> http://patchwork.xfs.org/patch/517/
Dave fixed the warnings not quite correctly, he switched from %d which
was totally wrong to %lu which is only correct on some 64-bit
architectures. %zd is the really correct format.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-21 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 11:34 [PATCH] xfstests: fix format string warnings in locktest.c Christoph Hellwig
2010-01-21 14:02 ` Alex Elder
2010-01-21 16:34 ` Alex Elder
2010-01-21 17:32 ` Christoph Hellwig [this message]
2010-01-21 17:50 ` Alex Elder
2010-01-21 17:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121173237.GA25322@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox